Add a custom block list to IP blocklist in the GUI?

[povoq (poVoq None)]

Continuing the discussion from Custom IP Blacklist:

---

Since there is now a IP blocklist in the GUI, would it be possible to have an option to easily add a custom block list?

[bonnietwin (Adolf Belka)]

@povoq

would it be possible to have an option to easily add a custom block list?

That would be possible if one of the forum members steps up and creates a patch for the changed code and submits it to the IPFire Development mailing list as explained in the Development section of the wiki.

I believe that most if not all the IPFire devs have more things on their lists already than they have time to support, without something new being added.

When new things need to be added (e.g. security related issue or feature) then currently something else either will be removed or delayed.

My feeling is that if no one steps forward to support it I doubt that it will get implemented.

[povoq (poVoq None)]

Sure, but it would really help if ipfire would allow standard Pull Requests on a platform like Codeberg.org and not depend on this horrible email git patch system, which is a huge barrier of entry to new contributors.

[hvacguy (Shaun HVAC)]

@povoq

Since there is now a IP blocklist in the GUI, would it be possible to have an option to easily add a custom block list?

the unofficial “Banish” Pligin.

Congratulations to the authors of Libloc

My latest version on Banish uses libloc to block on ASN as well as IP Address, CIDR and FQDN and adds a useful cgi set-up page to the IPFire menu and integrates into the IP Address Blocklists feature. It is available from: https://people.ipfire.org/~helix/banish/Banish-002.tar.gz ******* Banish-002.tar.gz ******** 2022-12-27 Requirements IPFire 2.27 (x86_64) - Core-Update 170 or later. This version of Banish adds the facility to block on Autonomous System Number (ASN) as well as the earl…

[bbitsch (Bernhard Bitsch)]

This can be a good starting point.
But the sources are old. Don’t know whether @helix is updating this. A first look into the archive shows that the structure of IPFire addons is missing ( install, update, uninstall skripts; ROOTFILE; … )
Just to add the files in the archive is not recommended!

[helix (Rob)]

As I have had very little feedback on Banish, I was under the impression that it was of little use to IPFire in general and therefore not updated this addon.
I run Banish on my firewall and have added a couple of bug fixes to my local version which I could apply to v.002 if anyone is interested so please reply here if they would be useful to you.
The current version on people.ipfire.org is a self extracting tar file.

Rob

[gw-ipfire (ipfire-test ipfire-test)]

hi
I’m interested if you can be pushed through update
Banish is very good
ty

[helix (Rob)]

@gw-ipfire

I’m interested if you can be pushed through update
Banish is very good

Thank you for your comments, I’m pleased you are finding Banish as useful as I do
I have been busy on another project so it will probably be after Christmas before I can update Banish. The update will improve the Banish list parsing but functionality will stay the same.

Rob

[hvacguy (Shaun HVAC)]

@bbitsch

look into the archive shows that the structure of IPFire addons is missing ( install, update, uninstall skripts; ROOTFILE; … )
Just to add the files in the archive is not recommended!

@helix
Is this something you are interested in
Doing?
To submit as a addon?
Happy holidays.

[helix (Rob)]

@hvacguy

Is this something you are interested in
Doing?
To submit as a addon?
Happy holidays.

I could do that but it’s not something I have done before although I have read the add-ons Wiki about what to do.

Do you think there would be sufficient interest in turning Banish into an add-on. It shouldn’t be too difficult as Banish was originally an addon for IPCop v1 over 20 years ago but the original author (Sid McLaurin) abandoned it when there wasn’t enough interest and IPCop add-ons installations were quite different to the IPfire ones.

I’d be pleased to hear your comments on this.

Rob

[hvacguy (Shaun HVAC)]

I would love to see it as a official addon.

[gw-ipfire (ipfire-test ipfire-test)]

hi
same is posibility
ty

[bonnietwin (Adolf Belka)]

As in post 4 of this thread

https://community.ipfire.org/t/add-a-custom-block-list-to-ip-blocklist-in-the-gui/13255/4

it already mentions that @helix has the banish option integrated into the IP Blocklist on his system.

It would seem to make more sense to me to submit a patch that integrates the banish capability into the IP Blocklist, together with the reasoning and explanation of what benefits the change provides rather than creating another addon that does the same as the core IP Blocklist but with some additional changes.

[gw-ipfire (ipfire-test ipfire-test)]

you’re right sinder the two would be nice if it’s possible

[helix (Rob)]

@bonnietwin

it already mentions that @helix has the banish option integrated into the IP Blocklist on his system.

It would seem to make more sense to me to submit a patch that integrates the banish capability into the IP Blocklist, together with the reasoning and explanation of what benefits the change provides rather than creating another addon that does the same as the core IP Blocklist but with some additional changes.

I would be happy to do that if you think it would be useful.

I had considered submitting a patch to IP Blocklist that would introduce a sources.d directory that would facilitate adding local blocklists to the ipblocklist sources which wouldn’t be overwritten when ipblocklist is upgraded. This could be Banish or any other personalised blocklist in the sources.d directory.

Would this be a useful alternative?

Rob

[bonnietwin (Adolf Belka)]

@helix

I had considered submitting a patch to IP Blocklist that would introduce a sources.d directory that would facilitate adding local blocklists to the ipblocklist sources which wouldn’t be overwritten when ipblocklist is upgraded. This could be Banish or any other personalised blocklist in the sources.d directory.

Would this be a useful alternative?

That was mentioned by Tim as being a potential follow-up step when the IP Blocklist was implemented in IPFire. Nothing has been provided since then.

So I think that would be a good approach to go for and it would be good if you could support that.
I know that I have so many things that I am working on, with a list of evaluations, bug fixes, package updates etc… that I would find it difficult to find the time to do anything myself.

[helix (Rob)]

@bonnietwin

So I think that would be a good approach to go for and it would be good if you could support that.
I know that I have so many things that I am working on, with a list of evaluations, bug fixes, package updates etc… that I would find it difficult to find the time to do anything myself.

From a quick look, it looks like a small patch to ipblocklist-functions.pl plus the addition of a sources.d directory to /var/ipfire/ipblocklist etc.

I’ll have a closer look.

Rob

[siosios]

@helix

bug fixes to my local version which I could apply to v.002

i would like to see those bug fixes, i have banish on my home system