Just a quick update, the process to better handle the pages rendered with tables has been started. To those who tested the first version, you can get the new one by doing the following:
# Remove the current version
cd ipfire-dark-theme
./patch.sh -r
# Get the latest version
git pull
# Install the latest version
./patch.sh
I’ve renamed the Todo
section to Roadmap in the README to give a better view on what is planned on this project.
I wanted to see if the same work could be accomplished without Javascript and use CSS only but unfortunately it’s not possible as this feature is only supported by Firefox.
Properly handling the pages rendered mainly with tables required to write some path detection logic to apply the CSS code required by each related pages conditionally. I did my best and tested several different methods to avoid that but there was no other way without having to change the way the tables are rendered.
To those who are wondering if the code is leaking any data or does some “call-to-home”, the answer is simply no. I have no will nor interest into that. The code has been written to rely only a single part of the detected URL called path
(or pathname
in Javascript) and nothing else. The detected path is then only stored in the browser memory and nowhere else.
The goal of this project is to provide the missing dark mode without having to alter the WUI files to maximize the portability. However, one file needed to be patched in order to include to the Javascript file responsible of the CSS code injection, environment detection (just to detect if the user environment is configured in dark mode or light mode only) and store the selected mode (dark or light).
Doing so will require more work from my part but less work for the dev team which is something that I think they will appreciate
There is another goal which is to keep the visual guideline of the default IPFire theme and just add the missing “dark” touches where it is necessary. Unfortunately, to maximize the readability on darker backgrounds, I had to slightly changes some colors like the green, red and blue colors to lighter ones to reduce contrast balance issues.
@bonnietwin , I understand better now what you said about the difficulty to maintain several themes, just patching half of the pages with tables took me more than 10 hours and the work is not finished yet
I’m gonna sleep now but I’ll try to cover all pages with tables that needs to be handled better later today.
Sorry for that long and kinda technical post, I just wanted to give more details about how things are done and what the patch is exactly doing.
Hope you’ll like this new version