Celeron J3160 capabilities with QoS

Networking Quality of Service
81

Another alternative approach is to run the nano command with -l (that is a lower case L) so you get line numbers.

nano -l /var/ipfire/qos/bin/makeqosscripts.pl

then scroll down to line number 212 and see what is there.

EDIT:-

So @arne_f took the existing makeqosscripts.pl file and modified two line to make the cake based version run with fq_codel.

If you have not had your makeqosscript.pl file updated because something went wrong during an upgrade then you would still have the previous version of makeqosscripts.pl, which is very different and that portion of the line I suggested would not be found.

Line 212 in that case would be

$qossettings{'CLASS'} = $classline[1];

I recall you having previous problems with missing or outdated files that had to be copied from the IPFire git repo.
If line 212 is from the old version of makeqosscripts.pl then I would suggest doing a fresh install and restore to ensure that all files are correctly brought up to date.

EDIT2:-
The reason I am suggesting a fresh install is that if you donā€™t have the updated makeqosscripts.pl file then you likely will also not have the following updated files

lib/udev/network-aqm
lib/udev/network-hotplug-bridges
lib/udev/rules.d/99-aqm.rules
srv/web/ipfire/cgi-bin/qos.cgi

which were also changed for the migration from fq_codel to cake.

82

Okā€¦ concept question: why that .pl file is not updated/overwritten when update is installed?

83

because something went wrong during the update before those files were updated during the extract_files step in the update script

https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/core/163/update.sh;h=5b35ed4df20fd56a27359e6b1dfbd15222a3f32b;hb=refs/heads/core163#l66

84

Thank you, @bonnietwin

You are correct, after I looked at my makeqosscript.pl file more closely today. I will have to schedule a time to do a fresh install and backup restore. Iā€™m not sure how that happened. Iā€™m pretty sure I did a fresh install and restore after the partition size issue a few years back. Maybe that happened after the update from fq_codel to cake, so the transition to cake never happened due to low free space from smaller partitions.

Iā€™m not remembering having to do this? Are you confusing me with another user, or am I just not remembering that this happened? :man_shrugging:

85

In that case you probably didnā€™t.

That could well be the case. Unfortunately couldnā€™t find it in my searching to find who it actually was, so maybe it never even happened!!!

86

@bonnietwin @arne_f

Unfortunately, IPFireā€™s backup includes makeqosscripts.pl. I donā€™t know if itā€™s supposed to, or a bug. Just this morning at 6am I drove into work, did a fresh backup, installed Core 186 from scratch to the system, checked the makeqosscripts.pl file and it was set up for CAKE. I then restored my backup, checked the file again, and it had reverted to my old version.

Fortunately, the old QoS still works fine. But I was hoping to get it switched over to CAKE. Any other suggestions?

87

I just checked and can confirm that the backup include file has the lines

var/ipfire/qos/*
var/ipfire/qos/bin/qos.sh

The second line specifies a specific file in the bin directory but the first line effectively says everything that is in the qos directory, which includes the bin directory.

I checked on of my backup files and that also shows it is backing up everything in the bin directory. This includes all the following files.

event-func.pl
makeqosscripts.pl
migrate.pl
parse-func.pl
RRD-func.pl

I would not expect any of these to be backed up. If any of these scripts have been updated then they would also be overwritten when a restore from backup is done.

To me this seems to definitely be a bug. Could you raise a bug for this please.

https://www.ipfire.org/docs/devel/bugzilla
Your IPFire People email address and password will be accepted as your IPFire Bugzilla login credentials.

In terms of how to deal with this in the short term, the only workaround suggestion I have is to take your backup file and open it with a graphical archive tool and delete the *.pl entries in the qos/bin/ directory.

I am using xfce4 with Arch Linux and the package in xfce4 is called xarchiver.

Other Linux distros will have different desktop applications available but they all should have some form of graphical archiver package.

I just did a test with that and I was able to delete the entries in the bin directory in the .ipf file.

If you donā€™t have a graphical system then you can do it on the command line by untar-ing the .ipf file, removing the .pl files from the bin directory and then re-tar into the .ipf file.

Then do a fresh install to get the correct script versions and restore from your modified .ipf file so that you get your config but without anything being overwritten in the qos/bin/ directory.

We will need to think how to change the backup, because the qos.sh file is also placed in the /bin directory but I think that might be desired to be backed up.
I will raise this and discuss it at the next IPFire devs meeting.

3 Likes
88

For anyone else reading along, I opened a bug for this issue here:
https://bugzilla.ipfire.org/show_bug.cgi?id=13736

Adolf is working on a patch. I will wait for the patch to be released, upgrade to whichever CU it happens to be in, make a fresh backup (which should now not include makeqosscripts.pl), then do a fresh install and restore, which should then get me current with QoS and CAKE.

Thanks for all your help, Adolf.

3 Likes