I have just done a backup on my CU164 running system and I found that a whole bunch of directories were not backed up.
I was missing
captive
connscheduler
ddns
dhcp
dhcpc
dma
However this can’t be directly related to the change to CU 164 as I carried that out on 14th March and I have a backup, that I run weekly from a script, which is dated 19th March and that has all the directories backed up.
Also the backup run by the CU164 change on the 14th also has all the directories.
Ones I am running today either from the WUI or using my script all have the above directories missing.
Actually I must check the whole list to see fi there are any others missing that would have been there in the past.
Don’t understand what is happening at the moment.
So there are a huge number missing from my backup.
Can you check your backup and see if the ones I have listed are also missing in your ipfire directory. This would show if the directories not being backed up are consistent for the two of us. Makes the fault easier to diagnose.
I may raise a bug for this but will first check out some of what you highlighted. My script was using backup.pl directly not backupctrl and the issue with backupctrl was a problem with the paths. I will have a look at that. Although what I don’t understand is why the backups were okay up to 19th March which is after I had updated to CU164
I think you were right about the backupctrl issue being related.
I think it was caused by a change issued in CU164 which changed the backup include and exclude files to have their entries as relative paths and not absolute paths. I think that may have then caused the backupctrl issue.
Either way, changing the include file paths back to absolute (ie prepending a / at the start of every line) has made my backup now include all the required directories.
I will have a look at testing out the path change that @Michael implemented to fix the backupctrl issue to confirm if that also fixes this problem - ie they are driven by the same root cause. However I will over to my vm testbed for that because I will have to copy in the modified backupctrl file from the git repository and the path change was made to one of the c files for backupctrl.
Anyway a simple temp fix for your running system is to add a / at the start of each line in /var/ipfire/backup/include
So I just ran CU166 (next) which has the backupctrl path fix and the fix looks to work in that the previous issue did not occur but there was another failure but that is due to an uninitialised variable in something that is still being worked on.
However, key thing is that with the backupctrl path fix in place the missing directories in the backup were still missing so it looks like this is a different bug so I will raise it in the IPFire Bugzilla.
The fix for that backupctrl issue is in next (CU166) and I installed it onto a vm on my vm testbed and it did not fix this problem of the missing directories in the backup. It may still be related to paths because of the change from absolute to relative paths in the include file but the paths change in suid.c for backupctrl is not enough on its own.
